Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPUnit 11 compatibility #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix PHPUnit 11 compatibility #30

wants to merge 2 commits into from

Conversation

rgson
Copy link

@rgson rgson commented Jun 3, 2024

Fixes the errors in PHPUnit 11:

There were 4 PHPUnit errors:                                                                                                                                                        
                                                                                                                                                                                    
1) Giggsey\Locale\Tests\DisplayRegionTest::testGetDisplayRegion                                                                                                                     
The data provider specified for Giggsey\Locale\Tests\DisplayRegionTest::testGetDisplayRegion is invalid                                                                             
Data Provider method Giggsey\Locale\Tests\DisplayRegionTest::dataDisplayRegions() is not static                                                                                     
                                                                                                                                                                                    
giggsey/Locale/tests/DisplayRegionTest.php:16                                                                                                                
                                                                                                                                                                                    
2) Giggsey\Locale\Tests\PrimaryLanguageTest::testGetPrimaryLanguage                                                                                                                 
The data provider specified for Giggsey\Locale\Tests\PrimaryLanguageTest::testGetPrimaryLanguage is invalid                                                                         
Data Provider method Giggsey\Locale\Tests\PrimaryLanguageTest::dataListOfPrimaryLanguages() is not static                                                                           
                                                                                                                                                                                    
giggsey/Locale/tests/PrimaryLanguageTest.php:15                                                                                                              
                                                                                                                                                                                    
3) Giggsey\Locale\Tests\PrimaryLanguageTest::testUnderscoreOrDash                                                                                                                   
The data provider specified for Giggsey\Locale\Tests\PrimaryLanguageTest::testUnderscoreOrDash is invalid                                                                           
Data Provider method Giggsey\Locale\Tests\PrimaryLanguageTest::dataUnderscoreOrDash() is not static                                                                                 
                                                                                                                                                                                    
giggsey/Locale/tests/PrimaryLanguageTest.php:250                                                                                                             
                                                                                                                                                                                    
4) Giggsey\Locale\Tests\RegionTest::testGetRegion                                                                                                                                   
The data provider specified for Giggsey\Locale\Tests\RegionTest::testGetRegion is invalid                                                                                           
Data Provider method Giggsey\Locale\Tests\RegionTest::dataListOfRegions() is not static                                                                                             
                                                                                                                                                                                    
giggsey/Locale/tests/RegionTest.php:15

@giggsey giggsey self-requested a review June 10, 2024 08:37
@rgson
Copy link
Author

rgson commented Jun 11, 2024

Seems coverage reporting needs a backward-incompatible change to phpunit.xml.dist. The <coverage> tag should be <source> now. But that doesn't work in PHPUnit <10.

@giggsey
Copy link
Owner

giggsey commented Jun 11, 2024

image

I'm not comfortable to remove PHP 7.4 support quite yet, so I think this PR will need to wait until those older PHP versions can be dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giggsey giggsey Awaiting requested review from giggsey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgson @giggsey